-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed to not use NetworkInfo class for Lollipop and above #455
base: RxJava2.x
Are you sure you want to change the base?
Conversation
Any feedback on this?? |
Hi @chaesung. Thanks for your PR. I didn't have time to perform the review of your code. I'll do it soon. Regards, |
Code looks quite fine. Maybe small adjustments can be done after merge. I'll test it later and if everything will be ok, I'll merge it. |
@pwittchen Thanks for the approval. Would it be possible to know when it would be merged? |
@pwittchen any feedback on this? |
Has this been merged? |
Please merge it |
I checked out this branch after fixing test configuration and I see, several tests are not passing. Unfortunately, we cannot see them here, because Travis CI were changed and this CI doesn't work anymore with old configuration. I need to fix this CI or migrate do GitHub actions... From what I see, |
…ccording to PR #455 related to utilization of the NetworkState class
I took your PR and added some adjustments in PR #469 regarding library logic and tests. I need to verify that and maybe add some more tests for the newer Android API. If everything will be working fine, I'll merge it. |
…ccording to PR #455 related to utilization of the NetworkState class
…ccording to PR #455 related to utilization of the NetworkState class
…ccording to PR #455 related to utilization of the NetworkState class
…ccording to PR #455 related to utilization of the NetworkState class
…ccording to PR #455 related to utilization of the NetworkState class
…ccording to PR #455 related to utilization of the NetworkState class
This PR introduces the following update:
Was concerned about issue #318
However I couldn't completely remove the NetworkInfo class in Connectivity class
I just changed it so that it would use the network callback api from Lollipop and above.
If you don't have time please give me some tips on how I should implement it or just dump in ideas in this PR.
I will try to work on it.
Hope to hear from you soon.