Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to not use NetworkInfo class for Lollipop and above #455

Open
wants to merge 1 commit into
base: RxJava2.x
Choose a base branch
from

Conversation

chaesung
Copy link

This PR introduces the following update:

Was concerned about issue #318

However I couldn't completely remove the NetworkInfo class in Connectivity class

I just changed it so that it would use the network callback api from Lollipop and above.

If you don't have time please give me some tips on how I should implement it or just dump in ideas in this PR.

I will try to work on it.

Hope to hear from you soon.

@chaesung
Copy link
Author

Any feedback on this??

@pwittchen
Copy link
Owner

Hi @chaesung.

Thanks for your PR. I didn't have time to perform the review of your code. I'll do it soon.

Regards,
Piotr

@pwittchen
Copy link
Owner

Code looks quite fine. Maybe small adjustments can be done after merge. I'll test it later and if everything will be ok, I'll merge it.

@chaesung
Copy link
Author

@pwittchen Thanks for the approval. Would it be possible to know when it would be merged?

@chaesung
Copy link
Author

@pwittchen any feedback on this?

@henryglendening-hh
Copy link

Has this been merged?

@jortas
Copy link

jortas commented Apr 18, 2022

Please merge it

@pwittchen
Copy link
Owner

pwittchen commented Dec 4, 2022

I checked out this branch after fixing test configuration and I see, several tests are not passing.

Unfortunately, we cannot see them here, because Travis CI were changed and this CI doesn't work anymore with old configuration. I need to fix this CI or migrate do GitHub actions...

From what I see, MarshmallowNetowrkObservingStrategy#propagateAnyConnectedState() method, needs and update to consider NetworkState besides NetworkInfo class to make it work properly and to make tests pass. You can try to fix it by yourself or I can take a look at it later.

pwittchen added a commit that referenced this pull request Dec 4, 2022
…ccording to PR #455 related to utilization of the NetworkState class
@pwittchen
Copy link
Owner

I took your PR and added some adjustments in PR #469 regarding library logic and tests. I need to verify that and maybe add some more tests for the newer Android API. If everything will be working fine, I'll merge it.

pwittchen added a commit that referenced this pull request Dec 4, 2022
…ccording to PR #455 related to utilization of the NetworkState class
pwittchen added a commit that referenced this pull request Dec 4, 2022
…ccording to PR #455 related to utilization of the NetworkState class
pwittchen added a commit that referenced this pull request Dec 4, 2022
…ccording to PR #455 related to utilization of the NetworkState class
pwittchen added a commit that referenced this pull request Dec 4, 2022
…ccording to PR #455 related to utilization of the NetworkState class
pwittchen added a commit that referenced this pull request Dec 4, 2022
…ccording to PR #455 related to utilization of the NetworkState class
pwittchen added a commit that referenced this pull request Dec 4, 2022
…ccording to PR #455 related to utilization of the NetworkState class
@pwittchen pwittchen self-assigned this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants