Fix flickering page number #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdujava
force-pushed
the
fix-page-num-flicker
branch
from
99ca85b
to
3dcf9b0
Compare
sebastinas
requested changes
Aug 23, 2024
Previously, when scrolling with dual-page layout positioned in the exact center (for example obtained by best-fit adjustment), the boundary handling could change horizontal alignment in such a way that resulted in flickering of the page number between two visible pages. Signed-off-by: Jonas Dujava <[email protected]>
jdujava
force-pushed
the
fix-page-num-flicker
branch
from
3dcf9b0
to
67aaacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when scrolling with dual-page layout positioned in the exact center (for example obtained by best-fit adjustment), the boundary handling could change horizontal alignment in such a way that resulted in flickering of the page number between two visible pages.
This simple fix seems to work, however, I am not sure whether this is the best way. Other suggestions are welcome.
Fixes #646.