Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ghost users #713

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Support for ghost users #713

merged 2 commits into from
Dec 14, 2024

Conversation

wd60622
Copy link
Collaborator

@wd60622 wd60622 commented Dec 11, 2024

Describe what this PR does / why we need it

Support for case where there is a deleted user for issues and PRs.

Works in both the issue / Pr buffers as well as the summary upon popup

Does this pull request fix one issue?

Closes #704

Describe how you did it

  • Add ghost icon
  • Use logic which the user is nil

Describe how to verify it

Check out an issue or PR where the user is deleted

Special notes for reviews

Checklist

  • Passing tests and linting standards
  • Documentation updates in README.md and doc/octo.txt

@wd60622 wd60622 linked an issue Dec 11, 2024 that may be closed by this pull request
@wd60622 wd60622 added the bug Something isn't working label Dec 11, 2024
@wd60622 wd60622 merged commit ac97828 into master Dec 14, 2024
4 checks passed
@wd60622 wd60622 deleted the 704-ghost-users-crash-buffers branch December 14, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost users crash buffers
1 participant