Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Demonstrated
[email protected]
logs DynamoDB access on the Database tab in APM with actual operations likeDynamoDB GetItemCommand
,DynamoDB PutItemCommand
, andDynamoDB UpdateItemCommand
[email protected]
removes the DynamoDB access from the Database tab and instead logs access to the dynamodb HTTPS endpoint as anExternal Service
without insight into which commands were run and how much time they tooklib/v3/lib-dynamodb.js
andlib/v3/client-dynamodb.js
files from@newrelic/[email protected]
nr-hooks.js
file, changing the type of the hooks for smithy-client and completely removing the hooks forlib-dynamodb
andclient-dynamod
Running the Demo
npm i
to install modulesnpm run build
to compile the TypeScriptnpm link
npm link @pwrdrvr/dynamodb-session-store
ts-node
results in no data being sent to NR)npm run build:example:express
NEW_RELIC_LICENSE_KEY=my_license_key npm run example:express:newrelic
dynamodb-session-store
in NewRelic APMComparing newrelic
10.4.0
to newrelic11.1.0
10.4.0
logs DynamoDB under the Database tab11.1.0
logs DynamoDB calls as External Services not as DatabaseRun this command (with license key substituted) to test changed versions:
Logs of Working Version
10.4.0
@smithy/smithy-client
AND@aws-sdk/client-dynamodb
Datastore metric names set
Instrumenting @smithy/smithy-client with onResolved hook
Instrumenting @aws-sdk/client-dynamodb with onResolved hook
Logs of Failing Version
11.1.0
@smithy/smithy-client
@aws-sdk/client-dynamodb
Datastore metric names set
Instrumenting @smithy/smithy-client with onRequire (module loaded) hook