Skip to content

Implemented the minio cert check controlling by the "MINIO_CERT_CHECK" setting variable. #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implemented the minio cert check controlling by the "MINIO_CERT_CHECK" setting variable. #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1e5382
Update storage.py
Haoke98 Mar 25, 2024
b89867b
Implemented the controll cert check by the MINIO_STORAGE_CERT_CHECK …
Haoke98 Mar 25, 2024
717f7e9
Chage MINIO_CERT_CHECK to MINIO_STORAGE_CERT_CHECK
Haoke98 Mar 25, 2024
19ce2ec
Update usage.md
Haoke98 Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ The following settings are available:
- `MINIO_STORAGE_STATIC_USE_PRESIGNED`: Determines if the static file URLs
should be pre-signed (default: `False`) By default set to False.

- `MINIO_STORAGE_CERT_CHECK`: Ignore SSL certificate verification and avoid SSL VerificationError when using self-generated SSL certificates. (default: `True`) By default set to True.


## Short Example

```py
Expand Down
2 changes: 2 additions & 0 deletions minio_storage/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ def _create_base_url_client(client: minio.Minio, bucket_name: str, base_url: str
# request), so don't just use client._region
region=client._get_region(bucket_name),
http_client=client._http,
cert_check=get_setting("MINIO_STORAGE_CERT_CHECK",True)
)

return base_url_client
Expand Down Expand Up @@ -367,6 +368,7 @@ def create_minio_client_from_settings(*, minio_kwargs=None):
"access_key": get_setting("MINIO_STORAGE_ACCESS_KEY"),
"secret_key": get_setting("MINIO_STORAGE_SECRET_KEY"),
"secure": get_setting("MINIO_STORAGE_USE_HTTPS", True),
"cert_check": get_setting("MINIO_STORAGE_CERT_CHECK",True),
}
region = get_setting("MINIO_STORAGE_REGION", None)
if region:
Expand Down