-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STY: Change variable names #3077
Conversation
Makes it obvious that "mode" is the new value of "prev_mode".
Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byt" for better readability.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3077 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 52 52
Lines 8778 8778
Branches 1600 1600
=======================================
Hits 8469 8469
Misses 184 184
Partials 125 125 ☔ View full report in Codecov by Sentry. |
Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byte_buffer" for better readability.
Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byte_buffer" for better readability.
In |
The |
Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byte_buffer" for better readability.
Thanks! PDF 2.0 specification section 8.6 Colour Spaces references Figure 20 — Colour specification and Figure 21 — Colour rendering. Roughly where do these fit into our codebase? |
There is no direct equivalent. They should mostly be covered by |
Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byt" for better readability.