Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Change variable names #3077

Merged
merged 5 commits into from
Jan 27, 2025
Merged

STY: Change variable names #3077

merged 5 commits into from
Jan 27, 2025

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jan 24, 2025

Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byt" for better readability.

j-t-1 added 2 commits January 24, 2025 16:17
Makes it obvious that "mode" is the new value of "prev_mode".
Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byt" for better readability.
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (493785c) to head (b0aa2d7).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3077   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          52       52           
  Lines        8778     8778           
  Branches     1600     1600           
=======================================
  Hits         8469     8469           
  Misses        184      184           
  Partials      125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

j-t-1 added 2 commits January 25, 2025 08:14
Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byte_buffer" for better readability.
Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byte_buffer" for better readability.
@j-t-1
Copy link
Contributor Author

j-t-1 commented Jan 25, 2025

In mode_map there are comments like "pos [0] will be used for 1 bit". Which array is "pos"?

@stefan6419846
Copy link
Collaborator

The position seems to correspond to line 117.

Make it obvious that "mode" is the new value of "prev_mode". Also change "by" to "byte_buffer" for better readability.
@j-t-1
Copy link
Contributor Author

j-t-1 commented Jan 25, 2025

The position seems to correspond to line 117.

Thanks!

PDF 2.0 specification section 8.6 Colour Spaces references Figure 20 — Colour specification and Figure 21 — Colour rendering. Roughly where do these fit into our codebase?

@stefan6419846
Copy link
Collaborator

There is no direct equivalent. They should mostly be covered by pypdf._xobj_image_helpers and pypdf.filters.

@stefan6419846 stefan6419846 merged commit a1aa6cc into py-pdf:main Jan 27, 2025
16 checks passed
@j-t-1 j-t-1 deleted the readability branch January 27, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants