Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Remove variable check_crlf_space #3096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jan 30, 2025

No description provided.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (33da49f) to head (44b01bc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
- Coverage   96.50%   96.50%   -0.01%     
==========================================
  Files          52       52              
  Lines        8806     8800       -6     
  Branches     1612     1612              
==========================================
- Hits         8498     8492       -6     
  Misses        183      183              
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

Doesn't this decrease readability/overview?

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jan 31, 2025

If I understand it, whether to check_crlf_space depends on if operator in ( b"Td", b"Tm", b"T*", b"Tj"). So the variable is recording something we already know, and so is redundant. A comment of what the check_crlf_space code is for may increase readability.

@stefan6419846 stefan6419846 added the on-hold PR requests that need clarification before they can be merged.A comment must give details label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold PR requests that need clarification before they can be merged.A comment must give details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants