[CSS] Local fonts, working fonts! #123
Conversation
sneakers-the-rat
changed the title
|
@sneakers-the-rat THANK YOU. i really wanted to self host them but didn't understand how to do it. i've actually been thinking about creating a pyos sphinx theme based on top of pydata theme like 2i2c has done so we just have the same theme for all of our books. but i really appreciate this help here as i was trying to vendor the fonts and didn't understand how to make it work!! |
| } | ||
|
|
||
| /* poppins-italic - latin */ | ||
| @font-face { |
There was a problem hiding this comment.
ok so somehow you're telling sass to find the fonts in our local fonts folder here so they are vendored rather than called from google fonts.
it would be great to make these changes everywhere - our website as well calls the google fonts website.
|
pre-commit.ci autofix |
There was a problem hiding this comment.
oh everything is passing now. i'll merge this as well. @sneakers-the-rat i pulled down the template that chris made for 2i2c and i'll try to incorporate your changes here into a pyos-sphinx-theme. that way we only have to make changes in one place to update all of our guidebooks. it will build on top of the pydata_sphinx_theme as we are doing here.
Currently the css specifies two fonts - 'Poppins' and 'Itim' that are supposed to be loaded by a
header.htmlpartial that is never included in the page.Rather than loading them from google fonts and compromise our visitors privacy it's relatively simple to self-host them, and blammo they work!
Sorry for the non-modular PR, but I was ending up repeating the content of #122 which this is based on
Before:
After:
not strictly comparable because my window was narrower in the after, but ya get it