Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config json to skip 403 url errors #139

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Add config json to skip 403 url errors #139

merged 4 commits into from
Oct 3, 2023

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Sep 27, 2023

closes #133
This should skip 403 errors in our markdown build. let's see

lwasser
lwasser commented Sep 27, 2023
View reviewed changes
config.json Outdated Show resolved Hide resolved
isabelizimm
isabelizimm reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes! this is exactly what i needed 🙌

@lwasser
Copy link
Member Author

lwasser commented Oct 3, 2023

ah yes! this is exactly what i needed 🙌

oh yay!! i must have forgotten to merge this - will do so now!! let me know if you catch any other issues @isabelizimm and thank you for noting this issue!!

@lwasser lwasser merged commit 2718f74 into main Oct 3, 2023
3 checks passed
@lwasser lwasser deleted the fix-ci branch October 3, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelizimm isabelizimm isabelizimm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure in CI: OSI website returns 403 (not a review)
2 participants
@lwasser @isabelizimm