Skip to content

Fixes to linear and saliency based blending - #466

Merged
RubenImhoff merged 4 commits into
masterfrom
RubenImhoff-linear_blending_update
Apr 23, 2025
Merged

RubenImhoff merged 4 commits into
masterfrom
RubenImhoff-linear_blending_update

Conversation

@RubenImhoff

@RubenImhoff RubenImhoff commented Apr 17, 2025 •

Copy link
Copy Markdown
Contributor

Fixes #467

PR to ensure that linear blending method can also handle multiple timesteps in the precip input variable, and to ensure that saliency-based blending works well when there are nans in the forecast.

  • Ensure linear blending can also handle multiple input timesteps.
  • Ensure that saliency-based blending works well when there are nans in the forecast. See the figure below from our Gallery, where it becomes clear that the saliency-based blending at +80 min becomes directly the same as NWP, while that is not warranted, as this is the time where the saliency-based blending should have just started. This seems to be caused by nans following from the _get_ranked_salience function.
  • Add tests (if needed).

image

@RubenImhoff RubenImhoff self-assigned this Apr 17, 2025
@RubenImhoff
RubenImhoff requested a review from dnerini April 17, 2025 09:42
@codecov

codecov Bot commented Apr 17, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (bc54616) to head (3dbde10).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   84.55%   84.56%           
=======================================
  Files         162      162           
  Lines       13456    13464    +8     
=======================================
+ Hits        11378    11386    +8     
  Misses       2078     2078           
Flag Coverage Δ
unit_tests 84.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RubenImhoff RubenImhoff changed the title Fix: ensure linear blending can also handle multiple input timesteps Fixes to linear and saliency based blending Apr 17, 2025
@RubenImhoff
RubenImhoff marked this pull request as draft April 17, 2025 14:10
@RubenImhoff
RubenImhoff requested a review from mats-knmi April 17, 2025 14:12
@RubenImhoff
RubenImhoff marked this pull request as ready for review April 17, 2025 16:22
Comment thread pysteps/blending/linear_blending.py Outdated
Comment thread pysteps/blending/linear_blending.py Outdated
RubenImhoff and others added 2 commits April 23, 2025 13:47
Co-authored-by: mats-knmi <145579783+mats-knmi@users.noreply.github.com>
@RubenImhoff
RubenImhoff merged commit d4ac4c0 into master Apr 23, 2025
@RubenImhoff
RubenImhoff deleted the RubenImhoff-linear_blending_update branch April 23, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saliency-based blending gives direct jump from nowcast to NWP

2 participants