-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Prtm2110 as a contributor for test #4866
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4866 +/- ##
========================================
Coverage 98.71% 98.71%
========================================
Files 304 304
Lines 23495 23495
========================================
Hits 23193 23193
Misses 302 302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ab04189
to
7f9b303
Compare
I think they should be added for "tests" and not "maintenance"? |
My idea was that #4842 did not add new tests for new/existing functionality, but rather was an effort for refactoring them. I would agree that such definitions would have an element of ambiguity attached to them. I'm happy to change it to "tests" if you want that, or should we add both, maybe? |
Yes, all-contributors badges can be ambiguous, but I'd say we stick to "tests" as "maintenance" is often linked with being a maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me – let's proceed with your suggestion. I've modified the output manually below.
@agriyakhetarpal I think the count of contributors needs to be updated too |
Probably better to just close this and re-create it |
Makes sense, closing |
Adds @Prtm2110 as a contributor for test.
This was requested by agriyakhetarpal in this comment