Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Prtm2110 as a contributor for test #4866

Closed
wants to merge 4 commits into from

Conversation

allcontributors[bot]
Copy link
Contributor

@allcontributors allcontributors bot commented Feb 20, 2025

Adds @Prtm2110 as a contributor for test.

This was requested by agriyakhetarpal in this comment

kratman
kratman previously approved these changes Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (998c18f) to head (0d237af).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4866   +/-   ##
========================================
  Coverage    98.71%   98.71%           
========================================
  Files          304      304           
  Lines        23495    23495           
========================================
  Hits         23193    23193           
  Misses         302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agriyakhetarpal agriyakhetarpal force-pushed the all-contributors/add-Prtm2110 branch from ab04189 to 7f9b303 Compare March 4, 2025 15:04
@Saransh-cpp
Copy link
Member

Saransh-cpp commented Mar 4, 2025

I think they should be added for "tests" and not "maintenance"?

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Mar 4, 2025

I think they should be added for "tests" and not "maintenance"?

My idea was that #4842 did not add new tests for new/existing functionality, but rather was an effort for refactoring them. I would agree that such definitions would have an element of ambiguity attached to them. I'm happy to change it to "tests" if you want that, or should we add both, maybe?

@Saransh-cpp
Copy link
Member

Yes, all-contributors badges can be ambiguous, but I'd say we stick to "tests" as "maintenance" is often linked with being a maintainer.

agriyakhetarpal
agriyakhetarpal previously approved these changes Mar 5, 2025
Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me – let's proceed with your suggestion. I've modified the output manually below.

@agriyakhetarpal agriyakhetarpal dismissed stale reviews from kratman and themself via 0351d65 March 5, 2025 19:40
@agriyakhetarpal agriyakhetarpal changed the title docs: add Prtm2110 as a contributor for maintenance docs: add Prtm2110 as a contributor for test Mar 5, 2025
@kratman
Copy link
Contributor

kratman commented Mar 5, 2025

@agriyakhetarpal I think the count of contributors needs to be updated too

@kratman
Copy link
Contributor

kratman commented Mar 5, 2025

Probably better to just close this and re-create it

@agriyakhetarpal
Copy link
Member

Makes sense, closing

@agriyakhetarpal agriyakhetarpal deleted the all-contributors/add-Prtm2110 branch March 5, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants