Better optimizer for initializing half-cell soc

[d-cogswell]

Description

scipy.opimize.root() occasionally causes numerical crashes during initialization of half-cell simulations. Switching to scipy.optimize.minimize() resolves the issue.

Fixes #4868

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

• No style issues: nox -s pre-commit
• All tests pass: nox -s tests
• The documentation builds: nox -s doctests
• Code is commented for hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[agriyakhetarpal]

Thanks, @d-cogswell – I've triggered the workflows for you.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (998c18f) to head (515e609).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4873   +/-   ##
========================================
  Coverage    98.71%   98.71%           
========================================
  Files          304      304           
  Lines        23495    23495           
========================================
  Hits         23193    23193           
  Misses         302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[martinjrobins]

Thanks @d-cogswell, largely this looks good and works for me as well, I've got a couple of questions below that should be addressed

[martinjrobins]

Thanks @d-cogswell , LGTM 😊

[agriyakhetarpal]

I can't comment on the half-cell equations side, but the change looks good to me, thanks!

[agriyakhetarpal]

@all-contributors please add @d-cogswell for code

[allcontributors]

@agriyakhetarpal

I've put up a pull request to add @d-cogswell! 🎉