fix: add py::mod_gil_used() spelling, support pedantic tests #5797
+45
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/fix/sizewarn
branch
4 times, most recently
from
f235563 to
94b3503
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/fix/sizewarn
branch
from
f5942e0 to
918fb72
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
changed the title
henryiii
changed the title
henryiii
changed the title
henryiii
changed the title
rwgk
reviewed
Aug 21, 2025
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/fix/sizewarn
branch
from
331a60e to
cef0ea7
Compare
Merged
henryiii
commented
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seeing if I can reproduce the warning-as-error in iminuit (scikit-hep/iminuit#1100). I seem to have failed, but at least we can pass pedantic now for earlier C++ versions. This was mostly working around the trailing comma issue that goes away in C++20.
I've added a new way to spell
py::mod_gil_not_used(false):py::mod_gil_used(). If we ever were to change the default (which might make sense if free-threading becomes default), it would be good to have a (nice) way to specify the previous behavior.Suggested changelog entry:
py::mod_gil_used()as replacement spelling topy::mod_gil_not_used(false).📚 Documentation preview 📚: https://pybind11--5797.org.readthedocs.build/