-
Notifications
You must be signed in to change notification settings - Fork 8
Update examples to support latest Psydac and Python 3.12 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Duplicate entries * 'keywords' field can't be repeated
This PR is ready for review! Here are the summary of changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have just a couple of comments
Thanks @kvrigor ! I have a few questions:
|
Good point @campospinto, the build of the Jupyter book should probably be tested on multiple platforms. As for the error, I do not see a substantial difference between the instructions in |
alright, then can you add a macos test @kvrigor ? If it passes, I'll try again to install on my mac. |
…o dig into the macOS pip issue.
I've also updated the |
Looks good! |
Thanks Paul! I have another question: when installing the dependencies, do you know if psydac is (re)installed ? In particular, Is there a simple way to be sure that you will be using your psydac version, if you previously had one installed? |
@campospinto Since psydac is declared as a git repo in
Yes--by editing
|
I see. And would it also work if one simply removes this line in his |
Yes, that would be the simplest solution! In this case psydac has to be manually installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Paul ! This looks good, I have a few questions -- essentially on the README for now.
Command used was `find . -type f -iname '*.ipynb' -exec nb-clean clean -eM {} \+`
Thanks Paul for the changes! |
It might be a good idea to externally link the IGA Python docs from the Psydac API docs. As a first step I'm making sure that all examples in this repository work with the latest version of Psydac.