Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid runtime warnings #355

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Avoid runtime warnings #355

merged 5 commits into from
Mar 1, 2024

Conversation

yguclu
Copy link
Member

@yguclu yguclu commented Nov 2, 2023 •
edited
Loading

Avoid runtime warnings from third-party libraries:

  • Use Numpy prod() instead of deprecated product()
  • Do not put non-Expr objects inside SymPy Matrix -- this is obtained by using 3D MutableDenseNDimArray objects containing scalars, instead of 2D Matrix objects containing tuples

TO DO

Do not cast complex values to real during post-processing (which will fix issue #353)

@yguclu yguclu requested review from a team and removed request for a team January 29, 2024 12:40
@yguclu yguclu marked this pull request as ready for review February 29, 2024 17:41
@yguclu yguclu requested a review from a team February 29, 2024 17:41
campospinto
campospinto approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@campospinto campospinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no particular comments from my side !

@yguclu yguclu merged commit b9bf209 into devel Mar 1, 2024
6 checks passed
@yguclu yguclu deleted the no-warnings branch March 1, 2024 11:05
@kvrigor kvrigor mentioned this pull request Apr 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@campospinto campospinto campospinto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yguclu @campospinto