developping vector #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalalium
commented
Dec 20, 2022
| @@ -33,11 +29,12 @@ def is_zero(x): | |||
| class FiniteVectorSpace(Basic): | |||
| """ | |||
| """ | |||
| def __new__(cls, name, shape=None): | |||
| def __new__(cls, name, dimension=None, field=None): | |||
|
|
|||
There was a problem hiding this comment.
Should we inform the dimension and field of a vector space? or should we inject that information later?
I think dimension should be used here instead of shape as it is the case in Psydac.
jalalium
commented
Dec 20, 2022
| return self._field | ||
|
|
||
| @property | ||
| def dtype(self): |
There was a problem hiding this comment.
For code generation, the data type can be infered from the field of the vector space if this information is not provided
jalalium
commented
Dec 20, 2022
| obj = Symbol.__new__(cls, name) | ||
| obj._space = space | ||
| obj._discretizable = False | ||
| if assumptions.get('values'): |
There was a problem hiding this comment.
is this the way to go to discretize vector?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.