add test for NS terminal expressions #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campospinto
changed the title
campospinto
changed the title
campospinto
added
enhancement
This was referenced Jul 26, 2024
Open
yguclu
reviewed
Aug 5, 2024
Comment on lines
+1920
to
+1925
| # [MCP 18.07.2024] for now, this test fails here because f is essentially 0: this should be fixed | ||
| print(f'a = {a}') | ||
| print(f'b = {b}') | ||
| print(f'f = {f}') | ||
| assert (f[0]-fx).simplify() == 0 | ||
| assert (f[1]-fy).simplify() == 0 |
There was a problem hiding this comment.
What does the comment line mean? Which test fails? Both assert statements pass
| # ... | ||
|
|
||
| # Verify that div(u) = 0 | ||
| assert (ux.diff(x) + uy.diff(y)).simplify() == 0 |
There was a problem hiding this comment.
Could we use div(ue) and TerminalExpr here?
d = TerminalExpr(div(ue), domain)
assert d.simplify() == 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of tests are added for terminal expressions used in Navier-Stokes equations. This is useful to verify exact solutions, eg in Psydac tests.
In psydac this branch is tested in the "testing" PR campospinto/psydac_dev#16