Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__version__ is a string #216

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

a-detiste
Copy link
Contributor

Hi,

I'm starting to package this for Debian.

@rhpvorderman
Copy link
Collaborator

Thanks! I am a happy debian user myself!

If there are any other things, please let me know so we can sort things out before the next freeze.

@a-detiste
Copy link
Contributor Author

Hi. There was a typo in the word "lenght" reported by Lintian.

I m packaging this to get asammdf in Debian.

@a-detiste
Copy link
Contributor Author

versioningit is not available in Debian, but I m already used to versioneer.py that does not work very well when building from .tar.gz so I patched it out

https://salsa.debian.org/python-team/packages/python-isal/-/blob/master/debian/patches/remove-versioningit.patch?ref_type=heads

Maybe there's room in the distribution for a "fake_versioneer.py /fake_versioningit.py" that always read the version at the top of the changelog... someday.

This is the kind of ugly patch that is typically not upstreamable, I just show it to you to show everything is fine.

@a-detiste
Copy link
Contributor Author

a-detiste commented Nov 25, 2024

I disabled fife tests for the initial upload.

The package is now in the NEW queue where it can stays hours/days/weeks (one can beg on IRC if it's urgent)

https://ftp-master.debian.org/new.html

That leaves plenty of time to try to fix these 5 tests.

export PYTHON_ISAL_LINK_DYNAMIC=1

export PYBUILD_TEST_ARGS=-k 'not test_compress_fast_best_are_exclusive \
                         and not test_compress_infile_outfile \
                         and not test_compress_infile_outfile_default \
                         and not test_decompress_cannot_have_flags_compression \
                         and not test_decompress_infile_outfile_error'

@rhpvorderman
Copy link
Collaborator

Hi. There was a typo in the word "lenght" reported by Lintian.

Fixed it jjust now.

@rhpvorderman
Copy link
Collaborator

versioningit is not available in Debian, but I m already used to versioneer.py that does not work very well when building from .tar.gz so I patched it out

Yes it is not ideal when working from no-git sources. For some reason the packaging always works when using CiBuildWheel so I am not that much bothered.

I prefer to use setuptools_scm. That works more intuitively, BUT it always includes the entire ISA-L source in the wheel. Which is a massive waste of space and I cannot turn it off. So I cannot use setuptools_scm for python-isal and python-zlib-ng.

@rhpvorderman rhpvorderman merged commit d7a6074 into pycompression:develop Nov 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants