Skip to content

Commit

Permalink
Close files properly in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
marcelm committed Jan 16, 2024
1 parent eaf712c commit e8150f2
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions tests/test_piped.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,15 +203,17 @@ def test_writer(tmp_path, writer):

def test_writer_has_iter_method(tmp_path, writer):
opener, extension = writer
with opener(tmp_path / f"out.{extension}") as f:
with opener(tmp_path / f"out{extension}") as f:
f.write("hello")
assert hasattr(f, "__iter__")


def test_reader_iter_without_with(reader):
opener, extension = reader
it = iter(opener(TEST_DIR / f"file.txt{extension}"))
f = opener(TEST_DIR / f"file.txt{extension}")
it = iter(f)
assert CONTENT_LINES[0] == next(it)
f.close()


@pytest.mark.parametrize("mode", ["rb", "rt"])
Expand Down Expand Up @@ -295,14 +297,16 @@ def test_iter_method_writers(writer, tmp_path):
opener, extension = writer
writer = opener(tmp_path / f"test{extension}", "wb")
assert iter(writer) == writer
writer.close()


def test_next_method_writers(writer, tmp_path):
opener, extension = writer
writer = opener(tmp_path / f"test.{extension}", "wb")
writer = opener(tmp_path / f"test{extension}", "wb")
with pytest.raises(io.UnsupportedOperation) as error:
next(writer)
error.match("not readable")
writer.close()


def test_pipedcompressionreader_wrong_mode():
Expand Down

0 comments on commit e8150f2

Please sign in to comment.