Skip to content

Prevent infinite loop in get_user_frame_and_stacklevel #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexmojaki merged 2 commits into from
Apr 24, 2025
Merged

Prevent infinite loop in get_user_frame_and_stacklevel #1031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b510219
Prevent infinite loop in get_user_frame_and_stacklevel
alexmojaki Apr 24, 2025
197bc44
Merge branch 'main' into alex/frame-loop
alexmojaki Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions logfire/_internal/stack_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ def get_user_frame_and_stacklevel() -> tuple[FrameType | None, int]:
return frame, stacklevel
frame = frame.f_back
stacklevel += 1
if stacklevel > 10_000: # pragma: no cover
# This is a safety check to prevent infinite recursion in case of a bug,
# as reported in https://github.com/pydantic/logfire/issues/1028.
# It should never happen in practice, but it's good to have a safety net.
break
return None, 0


Expand Down
Loading