Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim some rendundant CSS from _header.scss #1847

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Trim some rendundant CSS from _header.scss #1847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/pydata_sphinx_theme/assets/styles/sections/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@

// Contains the navigation links within the navbar
.navbar-nav {
display: flex;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootstrap already sets display: flex on .navbar-nav

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but the _navbar-nav.scss file changes the ul to display: block... Hmm, this might be more complicated than I realize. I'm going to put this PR into draft mode.


@include media-breakpoint-up($breakpoint-sidebar-primary) {
// Center align on wide screens so the dropdown button is centered properly
align-items: baseline;
Expand All @@ -106,10 +104,6 @@
@include header-link;
}

li a.nav-link.dropdown-item {
@include link-style-text;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line just applies the same mixin that _navbar-nav.scss appiles. The only difference is that the selector here, .bd-header .navbar-nav li a.nav-link.dropdown-item, is more specific than the other selector, .navbar-nav li a, but the specificity isn't needed to override anything, as far as I can tell.

}

// Dropdowns for the extra links
.dropdown {
button {
Expand Down
Loading