MAINT - Bump node version #1993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
Note this PR needs rebasing against main as I opened it before the fix to add FA to our build assets. Will do next week. |
Carreau
approved these changes
Oct 1, 2024
|
Personally I would wait |
|
So we are in agreement then and will leave it until 0.16.1 or so. |
|
May I suggest we may also use milestones for what for which version ? |
Made a 0.16.1 it's always easy to remove a milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
node.js 16for PST, which has long been out of LTS.This PR bumps node to v22, which is the Current version and will soon be moved to Active.
Ref: https://nodejs.org/en/about/previous-releases