Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Fix coverage workflow triggers #1996

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

trallard
Copy link
Collaborator

@trallard trallard commented Sep 30, 2024

When trying to cut the release candidate for the theme, the check_coverage workflow failed; however, this is not meant to run on release type events.

This PR fixes the syntax so that releases, schedules, and workflow_call type events are properly skipped.

Ref: https://github.com/pydata/pydata-sphinx-theme/actions/runs/11104806255/job/30850177121

@trallard trallard added kind: bug Something isn't working tag: CI Pull requests that update GitHub Actions code labels Sep 30, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@Carreau Carreau merged commit a4b3cb6 into pydata:main Sep 30, 2024
25 checks passed
@trallard trallard deleted the trallard/patch-coverage-action branch September 30, 2024 12:52
gabalafou pushed a commit to gabalafou/pydata-sphinx-theme that referenced this pull request Oct 6, 2024
When trying to cut the release candidate for the theme, the
`check_coverage` workflow failed; however, this is not meant to run on
`release` type events.

This PR fixes the syntax so that `releases, schedules, and
workflow_call` type events are properly skipped.

Ref:
https://github.com/pydata/pydata-sphinx-theme/actions/runs/11104806255/job/30850177121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working tag: CI Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants