Fix fill_value handling during unstack #10901
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the
fill_valuewhen performingunstack. The docs on unstack state (emphasis by me):If a full reindex is required during unstack, this is performed by the aligner, with the fill value handled here:
xarray/xarray/structure/alignment.py
Line 70 in 6da8c2c
If a full reindex is not required, the emphasized part in the docs is not true. Then, the program flow does not call the aligner but
_unstack_onceinstead here:xarray/xarray/core/dataset.py
Line 5606 in 6da8c2c
_unstack_once, however, does not handle the case where a variable name is not found in thefill_valuemapping.This PR fixes the latter issue.
Please let me know if I should add a test and mention a change in
whats-new.rst.whats-new.rstapi.rst