-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove special mapping of auto to {} in open_zarr
#11010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
e7015da
77c1189
797f1b4
01550f6
0494e7f
207ae91
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,7 @@ | |
| from xarray.core.utils import ( | ||
| FrozenDict, | ||
| HiddenKeyDict, | ||
| _default, | ||
| attempt_import, | ||
| close_on_error, | ||
| emit_user_level_warning, | ||
|
|
@@ -1400,7 +1401,7 @@ def open_zarr( | |
| store, | ||
| group=None, | ||
| synchronizer=None, | ||
| chunks="auto", | ||
| chunks=_default, | ||
| decode_cf=True, | ||
| mask_and_scale=True, | ||
| decode_times=True, | ||
|
|
@@ -1436,8 +1437,9 @@ def open_zarr( | |
| Array synchronizer provided to zarr | ||
| group : str, optional | ||
| Group path. (a.k.a. `path` in zarr terminology.) | ||
| chunks : int, dict, 'auto' or None, default: 'auto' | ||
| If provided, used to load the data into dask arrays. | ||
| chunks : int, dict, 'auto' or None, default: {} or None | ||
| Used to load the data into dask arrays. Default behavior is to use | ||
| ``chunks={}`` if dask is available, otherwise ``chunks=None``. | ||
|
|
||
| - ``chunks='auto'`` will use dask ``auto`` chunking taking into account the | ||
| engine preferred chunks. | ||
|
|
@@ -1558,7 +1560,7 @@ def open_zarr( | |
| if from_array_kwargs is None: | ||
| from_array_kwargs = {} | ||
|
|
||
| if chunks == "auto": | ||
| if chunks is _default: | ||
keewis marked this conversation as resolved.
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's issue a DeprecationWarning saying the default will switch to
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh I was actually thinking that we not do that part. The issue that we are trying to fix with this PR is really that
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 to merging this. It'd be nice to have the default be |
||
| try: | ||
| guess_chunkmanager( | ||
| chunked_array_type | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.