Skip to content

BUG: Fix invalid isinstance check using union types #11042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vkverma9534 wants to merge 3 commits into from
+13 −2
Closed

BUG: Fix invalid isinstance check using union types #11042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7b451b
BUG: Fix invalid isinstance check using union types
vkverma9534 Dec 21, 2025
15e3bef
Added parametrized test function
vkverma9534 Dec 22, 2025
b3748e8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xarray/core/parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def infer_template(
"Please supply the 'template' kwarg to map_blocks."
) from e

if not isinstance(template, Dataset | DataArray):
if not isinstance(template, (Dataset, DataArray)):
raise TypeError(
"Function must return an xarray DataArray or Dataset. Instead it returned "
f"{type(template)}"
Expand Down Expand Up @@ -351,7 +351,7 @@ def _wrapper(
result = func(*converted_args, **kwargs)

merged_coordinates = merge(
[arg.coords for arg in args if isinstance(arg, Dataset | DataArray)],
[arg.coords for arg in args if isinstance(arg, (Dataset, DataArray))],
join="exact",
compat="override",
).coords
Expand Down
11 changes: 11 additions & 0 deletions xarray/tests/test_dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,6 +1211,17 @@ def really_bad_func(darray):
xr.map_blocks(bad_func, map_da, kwargs=dict(a=map_da.chunk()))


@pytest.mark.parametrize("obj", [make_da(), make_ds()])
def test_map_blocks_accepts_da_ds_template(obj):
def identity(x):
return x

with raise_if_dask_computes():
result = xr.map_blocks(identity, obj, template=obj)

assert_identical(result, obj)


@pytest.mark.parametrize("obj", [make_da(), make_ds()])
def test_map_blocks(obj):
def func(obj):
Expand Down
Loading