Ensure SeasonResampler preserves datetime resolution
#11049
Merged
+56
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Dec 22, 2025
dcherian
changed the title
SeasonResmpler preserves datetime resolutionSeasonResampler preserves datetime resolution
spencerkclark
force-pushed
the
fix/SeasonResampler-datetime-resolution
branch
2 times, most recently
from
b6d768c to
f35dbc1
Compare
spencerkclark
force-pushed
the
fix/SeasonResampler-datetime-resolution
branch
from
f35dbc1 to
81fe4d3
Compare
Member
Author
|
Thanks for the review @dcherian. Sorry I was a bit too fast with marking this ready, but it should be good now if you'd like to give it another quick look. I was testing locally in an environment with the development version of pandas...older versions require a bit more gymnastics to get things right. |
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when looking into #11043. Since it is a separate issue, I figured I would split the fix out into its own PR.
SeasonResamplerdoes not preserve datetime resolution #11048whats-new.rst