Remove Unbuffered Sampling from cuGraph Examples #10079
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove use of __dict__ Co-authored-by: Matthias Fey <[email protected]>
remove use of __dict__ Co-authored-by: Matthias Fey <[email protected]>
simplify isinstance syntax Co-authored-by: Matthias Fey <[email protected]>
simplify isinstance call Co-authored-by: Matthias Fey <[email protected]>
remove explicit inheritance from object Co-authored-by: Matthias Fey <[email protected]>
remove direct __dict__ access Co-authored-by: Matthias Fey <[email protected]>
remove direct __dict__ access Co-authored-by: Matthias Fey <[email protected]>
…hi-nv/pytorch_geometric into initial-cugraph-storage
Create Initial Version of cuGraph Storage and Data Classes
alexbarghi-nv
requested review from
wsad1,
EdisonLeeeee and
rusty1s
as code owners
…pytorch_geometric into remove-unbuffered
|
ty will review by eod |
puririshi98
requested changes
Mar 1, 2025
akihironitta
approved these changes
Mar 1, 2025
| @@ -40,6 +40,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - Updated cuGraph Examples to use Buffered Sampling [#10079](https://github.com/pyg-team/pytorch_geometric/pull/10079) which keeps all data in memory and is significantly faster than the soon-to-be deprecated buffered sampling. | |||
There was a problem hiding this comment.
Suggested change
| - Updated cuGraph Examples to use Buffered Sampling [#10079](https://github.com/pyg-team/pytorch_geometric/pull/10079) which keeps all data in memory and is significantly faster than the soon-to-be deprecated buffered sampling. | |
| - Updated cuGraph examples to use buffered sampling which keeps data in memory and is significantly faster than the deprecated buffered sampling ([#10079](https://github.com/pyg-team/pytorch_geometric/pull/10079)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unbuffered sampling (dumping data to disk) since it is about to be deprecated and it has numerous bugs that we do not intend to fix.