Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinearMatrix.from_mapping, and replace BladeMap with it #306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eric-wieser
Copy link
Member

For the example application in spacetime algebra, bm(x) is at least 10x faster.

In theory we could now also write split without using bm at all:

split = LinearMatrix.from_mapping([
    # even subalgebra of D
    (D.scalar, P.scalar),
    (d01, p1),
    (d02, p2),
    (d03, p3),
    (d12, p12),
    (d23, p23),
    (d13, p13),
    (d0123, p123),

    # split(odd) = split(odd * d0)
    (d0, P.scalar),
    (d1, -p1),
    (d2, -p2),
    (d3, -p3),
    (d012, p12),
    (d013, p13),
    (d023, p23),
    (d123, -p123),
])

but I don't have a good enough understanding of what split.adjoint(p1) should be to feel comfortable doing this.

For the example application in spacetime algebra, `bm(x)` is at least 10x faster.
@arsenovic
Copy link
Member

so, pedagogically i dont think it adds anything to STA. however, i think its good because it teachs the transformation tools at the same time, and these are more generally useful

@arsenovic
Copy link
Member

i like this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants