Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI in newer Python versions #492

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Fix CI in newer Python versions #492

merged 2 commits into from
Mar 28, 2024

Conversation

utensil
Copy link
Member

@utensil utensil commented Mar 28, 2024

No description provided.

@utensil
Copy link
Member Author

utensil commented Mar 28, 2024

To my surprise, the CircleCI checker is still there, but then I deactivated it in https://github.com/pygae/galgebra/settings/hooks .

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (c31d0e4) to head (4c6efe8).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   78.87%   78.03%   -0.84%     
==========================================
  Files          17       17              
  Lines        4189     4193       +4     
==========================================
- Hits         3304     3272      -32     
- Misses        885      921      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utensil
Copy link
Member Author

utensil commented Mar 28, 2024

Notes on local testing various Python versions on my Mac:

brew install pyenv
pyenv install 3.9
pyenv init
source ~/.zprofile
pyenv shell 3.9
pip install -e .
pip install -r test_requirements.txt
pip install jupyter
jupyter notebook
# A smoke test
pytest --nbval examples/ipython/Terminal.ipynb --nbval-current-env --nbval-sanitize-with test/.nbval_sanitize.cfg

--current-env has been renamed to --nbval-current-env
--sanitize-with has been renamed to --nbval-sanitize-with
@utensil
Copy link
Member Author

utensil commented Mar 28, 2024

All CI green. The code coverage drop is due to adding a conftest.py. Merging.

@utensil utensil merged commit 0046162 into master Mar 28, 2024
7 of 8 checks passed
@utensil utensil added this to the 0.5.1 milestone Mar 30, 2024
@utensil utensil added the state: needs changelog Needs a changelog entry before the next release. Remove this label when the changelog is done. label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: needs changelog Needs a changelog entry before the next release. Remove this label when the changelog is done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant