Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by avoiding bugged version of pyproject-metadata package #3395

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

aatle
Copy link
Contributor

@aatle aatle commented Apr 4, 2025

pyproject-metadata version 0.9.1 has an incorrect dependency minimum version requirement for packaging, sometimes causing crashes during building, when pyproject-metadata==0.9.1 and packaging<23.2. See pypa/pyproject-metadata#239, issue got fixed but version 0.9.1 was released with the bug.

This affected #3379. Then it also failed tests on my fork's main branch, at https://github.com/aatle/pygame-ce/actions/runs/14256274454, so the fact that tests aren't failing on main right now is by chance.

Fix: Require that pyproject-metadata is not 0.9.1.

@aatle aatle requested a review from a team as a code owner April 4, 2025 02:26
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I’d prefer to see this restriction lifted when the most recent release works

@aatle
Copy link
Contributor Author

aatle commented Apr 4, 2025

I'm not sure I understand. Won't we still need the restriction when there is a new release of pyproject-metadata?

@oddbookworm
Copy link
Member

oddbookworm commented Apr 5, 2025

I'm not sure I understand. Won't we still need the restriction when there is a new release of pyproject-metadata?

Isn't this due to a borked dependency in a specific release version?
Edit: facepalm I shouldn't write things when half awake

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it!

@Starbuck5 Starbuck5 added this to the 2.5.4 milestone Apr 6, 2025
@Starbuck5 Starbuck5 merged commit c031e1a into pygame-community:main Apr 6, 2025
26 checks passed
@Starbuck5 Starbuck5 added CI Issue with the Continuous Integration (CI), the actions/bots that test things dependencies labels Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants