Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect additional metrics during collation #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mberr
Copy link
Member

@mberr mberr commented Jun 15, 2020

No description provided.

@mberr mberr requested a review from cthoyt June 15, 2020 11:21
@cthoyt
Copy link
Member

cthoyt commented Jun 15, 2020

Ahh its not so easy since there are groupby operations and all of the later scripts rely on the hits@10 being the only column that isn't getting grouped

@mberr
Copy link
Member Author

mberr commented Jun 15, 2020

Hm, so we would need to re-run the collation every time we want to have the plots for a new metric?

@cthoyt
Copy link
Member

cthoyt commented Jun 15, 2020

No, we just need to generalize the pipeline just a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants