Plot normalized dispersion #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoschD
added
Type: Bug
fsoubelet
previously approved these changes
Sep 1, 2023
Comment on lines
518
to
520
| """Plotting normalized dispersion function for normalized dispersion. | ||
| Normalized dispersion is special, as we only have X. | ||
| We therefore plot the delta in the second plot. """ |
There was a problem hiding this comment.
Bit repetitive with "normalized dispersion". For the second plot, do you mean second axis?
There was a problem hiding this comment.
"""Plotting normalized dispersion function for normalized dispersion.
Normalized dispersion is special, as we only have horizontal normalized dispersion.
We therefore plot the delta of normalized dispersion in the second plot in normalized dispersion plots. """
```There was a problem hiding this comment.
With second plot, Josch probably means the bottom plot of our standard two-plot windows in the GUI (and two-plot matplotlib outputs), usually showing X / Y, real / imag, or amp / phase.
+1 for using this unused space for the delta.
fsoubelet
previously approved these changes
Sep 13, 2023
|
Code Climate has analyzed commit d48469e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the plotting of normalized dispersion optics measurements and adding a "labels' feature.