Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new parameter: analyse_dpp #461

Merged
merged 31 commits into from
Oct 29, 2024
Merged

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Sep 18, 2024

Let the user choose if they want to analyse all files or only files with specific dpp (most likely the on-momentum files)

@JoschD JoschD self-assigned this Sep 20, 2024
@JoschD JoschD added Type: Feature A (suggetion for a) new feature or enhancement in functionality. Priority: Low Work on this if you have some spare time. Status: In Progress Currently being worked on. Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. labels Sep 20, 2024
@JoschD JoschD added Status: Blocked Cannot be worked on until something else happens (e.g. closing other issues). and removed Status: In Progress Currently being worked on. labels Sep 20, 2024
@JoschD JoschD marked this pull request as ready for review September 20, 2024 16:12
omc3/optics_measurements/phase.py Show resolved Hide resolved
omc3/optics_measurements/phase.py Outdated Show resolved Hide resolved
omc3/optics_measurements/phase.py Outdated Show resolved Hide resolved
tests/unit/test_hole_in_one.py Show resolved Hide resolved
@JoschD JoschD requested a review from a team as a code owner September 23, 2024 14:40
@JoschD JoschD added Status: On Hold Work currently stopped, but not for blocking reasons. and removed Status: Blocked Cannot be worked on until something else happens (e.g. closing other issues). labels Sep 27, 2024
@JoschD
Copy link
Member Author

JoschD commented Sep 27, 2024

Putting on hold until I have the time to device a test to check the output of compensated and uncompensated phase against each other (or the model)

@JoschD JoschD added Status: In Progress Currently being worked on. and removed Status: On Hold Work currently stopped, but not for blocking reasons. labels Oct 14, 2024
@JoschD JoschD added Status: Review Needed Work currently stopped, untils someone else reviews it. and removed Status: In Progress Currently being worked on. labels Oct 22, 2024
@JoschD JoschD requested a review from fsoubelet October 22, 2024 16:56
@JoschD JoschD added Priority: Medium Work on this. and removed Priority: Low Work on this if you have some spare time. labels Oct 28, 2024
@JoschD
Copy link
Member Author

JoschD commented Oct 28, 2024

Priority increased to "Normal" as this is very useful for injectors

@JoschD JoschD requested a review from jgray-19 October 28, 2024 17:10
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make PRs just for maintenance and flag the merge commits as revisions...

Minor questions but ok with me, we'll have to see about the order in which we merge the active PRs to resolve conflicts.

omc3/optics_measurements/data_models.py Show resolved Hide resolved
omc3/optics_measurements/crdt.py Show resolved Hide resolved
omc3/optics_measurements/measure_optics.py Show resolved Hide resolved
omc3/optics_measurements/measure_optics.py Show resolved Hide resolved
omc3/optics_measurements/rdt.py Show resolved Hide resolved
Copy link

codeclimate bot commented Oct 29, 2024

Code Climate has analyzed commit ccdbb24 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

The test coverage on the diff in this pull request is 87.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.9% (0.0% change).

View more on Code Climate.

@JoschD JoschD merged commit 4bb17b1 into master Oct 29, 2024
37 checks passed
@JoschD JoschD deleted the fix_use_all_files_for_rdt_calculation branch October 29, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. Priority: Medium Work on this. Status: Review Needed Work currently stopped, untils someone else reviews it. Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants