-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new parameter: analyse_dpp #461
Conversation
Putting on hold until I have the time to device a test to check the output of compensated and uncompensated phase against each other (or the model) |
Priority increased to "Normal" as this is very useful for injectors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make PRs just for maintenance and flag the merge commits as revisions...
Minor questions but ok with me, we'll have to see about the order in which we merge the active PRs to resolve conflicts.
Code Climate has analyzed commit ccdbb24 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 87.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.9% (0.0% change). View more on Code Climate. |
Let the user choose if they want to analyse all files or only files with specific dpp (most likely the on-momentum files)