Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MyPy 14 #210

Merged
merged 11 commits into from
Dec 26, 2024
Merged

Update MyPy 14 #210

merged 11 commits into from
Dec 26, 2024

Conversation

juanitorduz
Copy link
Contributor

Try to fix #209

@juanitorduz juanitorduz marked this pull request as draft December 26, 2024 11:01
@juanitorduz juanitorduz self-assigned this Dec 26, 2024
@juanitorduz juanitorduz added the maintenance Code style and repo configuration label Dec 26, 2024
@juanitorduz juanitorduz marked this pull request as ready for review December 26, 2024 11:09
Comment on lines +38 to +52
[tool.mypy]
files = "pymc_bart/*.py"
plugins = "numpy.typing.mypy_plugin"

[tool.mypy-matplotlib]
ignore_missing_imports = true

[tool.mypy-numba]
ignore_missing_imports = true

[tool.mypy-pymc]
ignore_missing_imports = true

[tool.mypy-scipy]
ignore_missing_imports = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way we can remove mypy.ini

@juanitorduz
Copy link
Contributor Author

@aloctavodia I think the latest commits actually solve #211 . I simply got rid of the float type. I think this is the best long term solution. WDYT?

@aloctavodia
Copy link
Member

Much nicer now!

@aloctavodia aloctavodia merged commit b84ba1c into pymc-devs:main Dec 26, 2024
4 checks passed
@juanitorduz juanitorduz deleted the update-mypy14 branch December 26, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code style and repo configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants