Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to "diagnosing biased inferences" #699

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

fonnesbeck
Copy link
Member

@fonnesbeck fonnesbeck commented Sep 11, 2024

Updated to v5


📚 Documentation preview 📚: https://pymc-examples--699.org.readthedocs.build/en/699/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Sep 12, 2024

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2024-09-12T12:46:29Z
----------------------------------------------------------------

If delta is exactly the same as target_accept better to use the latter.


Copy link

review-notebook-app bot commented Jan 15, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-01-15T07:43:55Z
----------------------------------------------------------------

This is the correct link to the original post https://mc-stan.org/learn-stan/case-studies/divergences_and_bias.html


Copy link

review-notebook-app bot commented Jan 15, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-01-15T07:43:56Z
----------------------------------------------------------------

...you can check out Thomas Wiecki's blog post, Why hierarchical models are awesome, tricky, and Bayesian on the same issue.

Clarify notation, the notation is standard for someone that already knows this expresion but can be opaque to someone new to the topic. Also instead of saying " the states of a Markov chain, q0..." maybe say using the posterior samples....

when mentioning split $\hat R$ we could add a reference to the paper (Vehtari, Aki, Andrew Gelman, Daniel Simpson, Bob Carpenter, and Paul-Christian Bürkner. 2021. “Rank-Normalization, Folding, and Localization: An Improved for Assessing Convergence of MCMC (with Discussion).”Bayesian Analysis 16 (2): 667–718. https://doi.org/10.1214/20-BA1221.) and/or link to https://arviz-devs.github.io/Exploratory-Analysis-of-Bayesian-Models/Chapters/MCMC_diagnostics.html#hat-r-r-hat


Copy link

review-notebook-app bot commented Jan 15, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-01-15T07:43:57Z
----------------------------------------------------------------

Do we need the Stan model?


Copy link

review-notebook-app bot commented Jan 15, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-01-15T07:43:58Z
----------------------------------------------------------------

remove "In the original post a single chain of 1200 sample is applied. However, since split R-hat is not implemented in ArviZ we fit 2 chains with 600 sample each instead."


Copy link

review-notebook-app bot commented Jan 15, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-01-15T07:43:59Z
----------------------------------------------------------------

az.summary(short_trace, round_to=2)


Copy link

review-notebook-app bot commented Jan 15, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-01-15T07:44:00Z
----------------------------------------------------------------

az.summary(longer_trace, round_to=2)


Copy link

review-notebook-app bot commented Jan 15, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-01-15T07:44:00Z
----------------------------------------------------------------

Do we need the Stan model?


Copy link

review-notebook-app bot commented Jan 15, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-01-15T07:44:01Z
----------------------------------------------------------------

az.summary(fit_ncp80, round_to=2)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant