replaced all pymc potential with pymc censored #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@fonnesbeck |
fonnesbeck
pushed a commit
to fonnesbeck/pymc-examples
that referenced
this pull request
Dec 20, 2024
* replaced all pymc potential with pymc censored * removed gumbel_sf function that is not being used * added rng to samplers * put back seeds for sampling data observations --------- Co-authored-by: Jonathan Dekermanjian <[email protected]>
fonnesbeck
pushed a commit
to fonnesbeck/pymc-examples
that referenced
this pull request
Dec 20, 2024
* replaced all pymc potential with pymc censored * removed gumbel_sf function that is not being used * added rng to samplers * put back seeds for sampling data observations --------- Co-authored-by: Jonathan Dekermanjian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AFT Weibull notebook to use
pm.Censoredinstead ofpm.PotentialRelated to #747
I updated all 3 parameterizations of the AFT Weibull model to utilize
pm.Censoredinstead ofpm.Potential. I also added into the markdown, after thepm.Potentialis discussed, why we would rather usepm.Censored.For the 1st two parameterizations the estimates are the same using
pm.Censoredas they are withpm.Potentialfor the last parameterization the parameter estimates are slightly shifted.