Implement Symmetric and Asymmetric Multivariate Laplace distributions #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
mv_laplace
branch
2 times, most recently
from
c98ff2e to
b5e1b41
Compare
ricardoV94
commented
Nov 7, 2024
|
|
||
|
|
||
| @pytest.mark.xfail(reason="Not sure about equivalence. Test fails") | ||
| def test_asymmetric_matches_univariate_logp(): |
There was a problem hiding this comment.
I was expecting these to be equivalent. The means and variances match, but not the logp. Either I did something wrong or the equivalence is not real / like this.
ricardoV94
commented
Nov 7, 2024
| from pytensor.tensor.random.utils import normalize_size_param | ||
|
|
||
|
|
||
| class Kv(BinaryScalarOp): |
There was a problem hiding this comment.
I'll move this to PyTensor before merging this PR
ricardoV94
force-pushed
the
mv_laplace
branch
from
b5e1b41 to
e3aab90
Compare
ricardoV94
force-pushed
the
mv_laplace
branch
from
e3aab90 to
e1680f0
Compare
|
Deprecation failures should be fixed by pymc-devs/pymc#7564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Bump PyMC dependency