Fixed an issue with m4_3b model which returned a negative b-value not consistent with output from textbook
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsistent with what's in the textbook. I've written a line of code to properly generate a log-normal distribution for the b value so that it results in a positive value when you return the summary for .
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous$\beta$ -value which isn't consistent with what's in Prof. McElreath's "Statistical Rethinking" textbook. I've written a line of code to properly generate a log-normal distribution for the $\beta$ -value so that it results in a positive value (i.e. roughly 0.902) when you return the summary table for
m4_3bmodel resulted in a negativetrace_4_3b. I'm planning to submit more PR's as I read through the text so any good feedback for my first PR would be helpful!Thank you for opening a pull request!
Please check our style guide, and also make sure that the notebooks you've modified pass the
pre-commitchecks. If, for example, you modifiednotebook1.ipynbandnotebook2.ipynb, you could do this by running:You may need to run it a couple of times before all the checks pass.