-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #7563 #7573
base: main
Are you sure you want to change the base?
Fix for issue #7563 #7573
Conversation
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including cdf, mean, and random methods.
] |
Hi @tanishy7777 the idea is to change all the cases where this happened, not just MvNormal |
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance.
I've implemented the changes as per your suggestions in the latest commit. Apologies for the delayed response my end-semester exams were going on. @ricardoV94 |
Does this happen only in multivariate.py? |
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance, etc.
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance.
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood including log-cdf, log-pdf.
Oh ok, will make the necessary changes. I think only the pymc/distributions folder has the files where the changes need to be made right? |
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance and covariance.
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality.
I have updated all the files that need to be changes in the pymc/distributions folder. Please let me know if any other changes need to be made or if anything needs to be modified @ricardoV94 @twiecki |
Replaced "log-likelihood" with "distribution" in for all the classes where distributions is more appropriate rather than log-likelihood.
Description
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance and covariance.
Related Issue
x log-likelihood
#7563Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7573.org.readthedocs.build/en/7573/