Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename compile_pymc to compile #7606

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Dec 5, 2024

This function is becoming increasingly more important, so it deserves a less silly name


📚 Documentation preview 📚: https://pymc--7606.org.readthedocs.build/en/7606/

@ricardoV94 ricardoV94 added the major Include in major changes release notes section label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.84%. Comparing base (955ac23) to head (1e81087).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pymc/pytensorf.py 50.00% 2 Missing ⚠️
pymc/testing.py 75.00% 1 Missing ⚠️
pymc/variational/opvi.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7606      +/-   ##
==========================================
- Coverage   92.85%   92.84%   -0.02%     
==========================================
  Files         106      106              
  Lines       17742    17745       +3     
==========================================
+ Hits        16474    16475       +1     
- Misses       1268     1270       +2     
Files with missing lines Coverage Δ
pymc/backends/base.py 88.69% <100.00%> (ø)
pymc/func_utils.py 88.63% <100.00%> (ø)
pymc/gp/util.py 97.56% <100.00%> (ø)
pymc/initial_point.py 99.02% <100.00%> (ø)
pymc/model/core.py 92.84% <100.00%> (ø)
pymc/sampling/forward.py 96.15% <100.00%> (ø)
pymc/smc/kernels.py 98.16% <100.00%> (ø)
pymc/step_methods/metropolis.py 93.02% <100.00%> (ø)
pymc/step_methods/slicer.py 96.84% <100.00%> (ø)
pymc/testing.py 89.77% <75.00%> (ø)
... and 2 more

Copy link
Member

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is also becoming central for Kulprit and relevant for some functionality in PreliZ. So glad to have a better name.

@ricardoV94 ricardoV94 merged commit 6cdfc30 into pymc-devs:main Dec 10, 2024
23 checks passed
@ricardoV94 ricardoV94 deleted the rename_compile_pymc branch December 10, 2024 13:43
@aloctavodia
Copy link
Member

I just realized that compile is one of the built-in functions in Python https://docs.python.org/3/library/functions.html#compile

@ricardoV94
Copy link
Member Author

I just realized that compile is one of the built-in functions in Python https://docs.python.org/3/library/functions.html#compile

I don't think that's a problem, it's not commonly used and can still be accessed by builtins.compile. Stuff like abs and sum is much more common and also shadowed by pytensor/numpy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Include in major changes release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants