Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slowest test issue CI/CD #1125

Merged
merged 7 commits into from
Dec 26, 2024
Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Dec 13, 2024

Description

Adding a CI/CD to populate #1124

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1125.org.readthedocs.build/en/1125/

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 13, 2024

A lot more sections than PyMC Marketing... Should I try for some formatting or would shortening the section "summary" still convey the same information?

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (231a977) to head (cb4dcec).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1125   +/-   ##
=======================================
  Coverage   82.10%   82.10%           
=======================================
  Files         185      185           
  Lines       48130    48130           
  Branches     8669     8669           
=======================================
  Hits        39519    39519           
  Misses       6444     6444           
  Partials     2167     2167           

@ricardoV94
Copy link
Member

We can omit the following:

  • python3.10 runs
  • float32 runs (no reason these should be slower than the float64)
  • The benchmark suite as it doesn't make sense to "speedup" so take that out as well

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 13, 2024

We can omit the following:

  • python3.10 runs
  • float32 runs (no reason these should be slower than the float64)
  • The benchmark suite as it doesn't make sense to "speedup" so take that out as well

Done. I've updated the issue with that filter. See how it looks there

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 13, 2024

I am looking into adding total time next to each section. I think that would be helpful for summary

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to see if I understand, this reads the times from the GitHub CI logs?

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 14, 2024

just to see if I understand, this reads the tones from the GitHub CI looks?

Tones? The issue at the moment will be how it looks every 6 hours

@ricardoV94
Copy link
Member

ricardoV94 commented Dec 14, 2024

just to see if I understand, this reads the tones from the GitHub CI looks?

Tones? The issue at the moment will be how it looks every 6 hours

reads the times from the GitHub logs. Fat fingers

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 14, 2024

reads the times from the GitHub logs. Fat fingers

Correct from the CI job rather than from pytest runs. So there might be some cushion added to that with job spin up, etc

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 14, 2024

But gives some ball park estimate of times for each

@wd60622
Copy link
Contributor Author

wd60622 commented Dec 16, 2024

Any more feedback @ricardoV94 ?

@ricardoV94 ricardoV94 merged commit 83c6b44 into pymc-devs:main Dec 26, 2024
61 of 62 checks passed
@ricardoV94
Copy link
Member

Thanks @wd60622

@ricardoV94
Copy link
Member

My question above wasn' clear. I was confirming this job does not need to run seperate CI tests, but instead simply reads the logs of the existing CI tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants