Skip to content

Refactor advanced subtensor #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jaanerik wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Refactor advanced subtensor #1756

jaanerik wants to merge 7 commits into from

Conversation

@jaanerik
Copy link

@jaanerik jaanerik commented Nov 28, 2025

Description

Allows vectorizing AdvancedSetSubtensor.

Gemini picks up where Copilot left off.

Related Issue

Checklist

  • Checked that the pre-commit linting/style checks pass (ruff removed whitespace etc from copilot commits also I think)
  • Changed tests that prove the fix is effective or that the new feature works
  • Added necessary documentation (docstrings and/or example notebooks)
  • If you are a pro: each commit corresponds to a relevant logical change

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copilot AI and others added 6 commits November 28, 2025 16:41
@jaanerik jaanerik force-pushed the refactor-advanced-subtensor branch 2 times, most recently from 3ce54c7 to 92f61ed Compare December 1, 2025 08:23
@jaanerik jaanerik marked this pull request as ready for review December 2, 2025 09:49
@jaanerik jaanerik force-pushed the refactor-advanced-subtensor branch from 92f61ed to a6cb68d Compare December 2, 2025 11:23
@jaanerik jaanerik mentioned this pull request Dec 2, 2025
Closed
11 tasks
@jaanerik jaanerik force-pushed the refactor-advanced-subtensor branch from a6cb68d to a4a305c Compare December 4, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reconsider use of SliceType and NoneType Variables as inputs to AdvancedIndexing

1 participant

@jaanerik