-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on implementing Pytorch Ops (and CumOp) #837
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f007c0d
Add Pytorch support for Cum Op
HarshvirSandhu 6ae355f
Modify test for Cum op
HarshvirSandhu 33463fc
Raise TypeError if axis not int or None
HarshvirSandhu bf905cb
Fix init method of CumOp
HarshvirSandhu debc3e0
Extend tutorial on documentation for Pytorch
HarshvirSandhu 2bc7ddc
Add tab for Numba
HarshvirSandhu ec87e4e
Add intersphinx mapping
HarshvirSandhu a6e6bd8
Parametrize dtype
HarshvirSandhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import torch | ||
|
||
from pytensor.link.pytorch.dispatch.basic import pytorch_funcify | ||
from pytensor.tensor.extra_ops import CumOp | ||
|
||
|
||
@pytorch_funcify.register(CumOp) | ||
def pytorch_funcify_Cumop(op, **kwargs): | ||
dim = op.axis | ||
mode = op.mode | ||
|
||
def cumop(x, dim=dim): | ||
if dim is None: | ||
x = x.reshape(-1) | ||
dim = 0 | ||
if mode == "add": | ||
return torch.cumsum(x, dim=dim) | ||
else: | ||
return torch.cumprod(x, dim=dim) | ||
|
||
return cumop |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,38 @@ | ||||||
import numpy as np | ||||||
import pytest | ||||||
|
||||||
import pytensor.tensor as pt | ||||||
from pytensor.configdefaults import config | ||||||
from pytensor.graph import FunctionGraph | ||||||
from tests.link.pytorch.test_basic import compare_pytorch_and_py | ||||||
|
||||||
|
||||||
@pytest.mark.parametrize( | ||||||
"axis", | ||||||
[ | ||||||
None, | ||||||
1, | ||||||
], | ||||||
) | ||||||
def test_pytorch_CumOp(axis): | ||||||
"""Test PyTorch conversion of the `CumOp` `Op`.""" | ||||||
|
||||||
# Create a symbolic input for the first input of `CumOp` | ||||||
a = pt.matrix("a") | ||||||
|
||||||
# Create test value tag for a | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
test_value = np.arange(9, dtype=config.floatX).reshape((3, 3)) | ||||||
|
||||||
# Create the output variable | ||||||
out = pt.cumsum(a, axis=axis) | ||||||
|
||||||
# Create a PyTensor `FunctionGraph` | ||||||
fgraph = FunctionGraph([a], [out]) | ||||||
|
||||||
# Pass the graph and inputs to the testing function | ||||||
compare_pytorch_and_py(fgraph, [test_value]) | ||||||
|
||||||
# For the second mode of CumOp | ||||||
out = pt.cumprod(a, axis=axis) | ||||||
fgraph = FunctionGraph([a], [out]) | ||||||
compare_pytorch_and_py(fgraph, [test_value]) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just no need for any kwargs. The function will only ever receive the node inputs