Added PyTorch link and unit tests for argmax #900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Jul 8, 2024
| ) | ||
| @pytest.mark.parametrize( | ||
| "axis", | ||
| [None, 1, (0,)], |
There was a problem hiding this comment.
Can you make the test tensor a tensor3 (3 dims), and test also axis=(0, 2)? This is something PyTensor supports but not e.g., numpy and perhaps pytorch as well. In that case you'll need to copy the logic used in perform instead of just calling argmax. If it works, great!
There was a problem hiding this comment.
In general with axis Ops we should always test axis=None, axis=(i,) and axis=(i, j), for 3d inputs, so we test all, a single axis or partial axes
48 tasks
|
I will merge the content of this PR into #878. |
As I wrote in the other PR this is not something we usually prefer. What was the reason that led you to do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented the PyTorch link and unit tests for the
ArgmaxOp.Related Issue
Checklist
Type of change