-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nlinalg Ops in PyTorch #920
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
- Coverage 81.60% 81.60% -0.01%
==========================================
Files 178 179 +1
Lines 47209 47271 +62
Branches 11478 11481 +3
==========================================
+ Hits 38527 38574 +47
- Misses 6496 6511 +15
Partials 2186 2186
|
Looks great, but I think a few of those Ops are already being addressed in other PRs. |
I see. I mixed the linalg and math ops because they were in the same file. Sorry about that. What should I do ? Should I keep only the linalg ops in this PR? |
@ricardoV94, what about |
Should have been handled as part of the CAReduce, unless we missed it |
a334c6a
to
2854c37
Compare
There are some conflicts, and a small comment on the test. Otherwise looks good to me |
Implemented Ops: - Argmax - Max - Dot - SVD - Det - SLogDet - Eig - Eigh - KroneckerProduct - MatrixInverse - MatrixPinv - QRFul
Replaced instances using Blockwise by the Op constructor.
425330f
to
2d061a5
Compare
Description
Implemented Ops:
Related Issue
Checklist
Type of change