-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pymc dependency #1269
base: main
Are you sure you want to change the base?
Bump pymc dependency #1269
Conversation
Thanks for this one! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
===========================================
- Coverage 95.34% 36.10% -59.24%
===========================================
Files 47 47
Lines 4963 4913 -50
===========================================
- Hits 4732 1774 -2958
- Misses 231 3139 +2908 ☔ View full report in Codecov by Sentry. |
There are just two failing tests (yay!) FAILED tests/clv/models/test_gamma_gamma.py::TestGammaGammaModel::test_spend[True]
FAILED tests/test_model_builder.py::test_fit_random_seed_reproducibility[rng] |
Closes #726 |
AFAICT it's a seed problem. standard deviation is similar to old version, and I could get it to fail then if I changed the seed. Making tolerance higher |
The second failure seems to be a regression in PyMC regarding seeding with generators: pymc-devs/pymc#7612 |
9f99a70
to
7511d19
Compare
7511d19
to
2a4b943
Compare
Very specific appreciation noted :D |
So, do we need to wait for this to be fixed in PyMC before merging this one? Or shall we skip this test (in the meantime)? |
This is buggy behavior so I would wait until the next release with the fix |
Agua de Mayo |
The next |
What does that mean? 🤔 |
Next pymc release |
Agua de Mayo may be translated as something is godsend. Context: I got a new Apple Silicon machine last week. Making blas work has been painful. I made it work following this release of pytensor you mentioned somewhere else. However that version is not supported in the pymc-marketing library. So indeed this PR is godsend to me. |
@wd60622 Is there anything holding this back? |
@ricardoV94 mentioned non deterministic behavior with pymc version |
Closes #726
📚 Documentation preview 📚: https://pymc-marketing--1269.org.readthedocs.build/en/1269/