Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pymc dependency #1269

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ricardoV94
Copy link
Contributor

@ricardoV94 ricardoV94 commented Dec 13, 2024

Closes #726


📚 Documentation preview 📚: https://pymc-marketing--1269.org.readthedocs.build/en/1269/

@juanitorduz
Copy link
Collaborator

Thanks for this one!

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.10%. Comparing base (39028fe) to head (e69031b).

Files with missing lines Patch % Lines
pymc_marketing/clv/distributions.py 54.54% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (39028fe) and HEAD (e69031b). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (39028fe) HEAD (e69031b)
11 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1269       +/-   ##
===========================================
- Coverage   95.34%   36.10%   -59.24%     
===========================================
  Files          47       47               
  Lines        4963     4913       -50     
===========================================
- Hits         4732     1774     -2958     
- Misses        231     3139     +2908     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz
Copy link
Collaborator

There are just two failing tests (yay!)

FAILED tests/clv/models/test_gamma_gamma.py::TestGammaGammaModel::test_spend[True]
FAILED tests/test_model_builder.py::test_fit_random_seed_reproducibility[rng]

@wd60622
Copy link
Contributor

wd60622 commented Dec 13, 2024

Closes #726

tests/test_mlflow.py Outdated Show resolved Hide resolved
@ricardoV94 ricardoV94 changed the title Bump pymc dep Bump pymc dependency Dec 13, 2024
@ricardoV94
Copy link
Contributor Author

ricardoV94 commented Dec 13, 2024

FAILED tests/clv/models/test_gamma_gamma.py::TestGammaGammaModel::test_spend[True]

AFAICT it's a seed problem. standard deviation is similar to old version, and I could get it to fail then if I changed the seed. Making tolerance higher

@ricardoV94
Copy link
Contributor Author

The second failure seems to be a regression in PyMC regarding seeding with generators: pymc-devs/pymc#7612

@ricardoV94
Copy link
Contributor Author

Thanks for this one!

Very specific appreciation noted :D

@juanitorduz
Copy link
Collaborator

The second failure seems to be a regression in PyMC regarding seeding with generators: pymc-devs/pymc#7612

So, do we need to wait for this to be fixed in PyMC before merging this one? Or shall we skip this test (in the meantime)?

@ricardoV94
Copy link
Contributor Author

This is buggy behavior so I would wait until the next release with the fix

@PabloRoque
Copy link
Contributor

Agua de Mayo

@ColtAllen
Copy link
Collaborator

This is buggy behavior so I would wait until the next release with the fix

The next pymc-marketing release, or next pymc release?

@ricardoV94
Copy link
Contributor Author

Agua de Mayo

What does that mean? 🤔

@ricardoV94
Copy link
Contributor Author

This is buggy behavior so I would wait until the next release with the fix

The next pymc-marketing release, or next pymc release?

Next pymc release

@PabloRoque
Copy link
Contributor

What does that mean? 🤔

Agua de Mayo may be translated as something is godsend.

Context: I got a new Apple Silicon machine last week. Making blas work has been painful. I made it work following this release of pytensor you mentioned somewhere else.

However that version is not supported in the pymc-marketing library. So indeed this PR is godsend to me.

@ColtAllen ColtAllen mentioned this pull request Dec 20, 2024
13 tasks
@aseyboldt
Copy link
Contributor

@wd60622 Is there anything holding this back?

@wd60622
Copy link
Contributor

wd60622 commented Dec 20, 2024

@wd60622 Is there anything holding this back?

@ricardoV94 mentioned non deterministic behavior with pymc version

PabloRoque added a commit to PabloRoque/pymc-marketing that referenced this pull request Jan 2, 2025
PabloRoque added a commit to PabloRoque/pymc-marketing that referenced this pull request Jan 2, 2025
PabloRoque added a commit to PabloRoque/pymc-marketing that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for PyMC 5.16 release
6 participants