Repository navigation
Convert TOC y through CropBox origin, not crop height - #5111
Merged
julian-smith-artifex-com merged 1 commit intoNov 3, 2026
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
We can't look at merging this because it is failing tests. Could you take a look? Otherwise we'll close this PR soon. |
Contributor
Author
|
Rebased onto current The earlier CI failure in |
gyanu2507
force-pushed
the
fix/set-toc-cropbox-y
branch
from
October 28, 2026 14:41
2393e77 to
2e6c025
Compare
set_toc treated the y as relative to a crop box whose origin is (0, 0). PDF destinations are in default user space, so a shifted CropBox offset the round-trip by CropBox.y0. Rebased onto current main so CI picks up the updated MuPDF warning expectations in test_3569. Fixes #4484
julian-smith-artifex-com
force-pushed
the
fix/set-toc-cropbox-y
branch
from
November 3, 2026 16:09
2e6c025 to
a3baf7c
Compare
JorjMcKie
approved these changes
Nov 3, 2026
Collaborator
|
This PR is now merged. Many thanks for submitting it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_tocconverted a y value withcropbox.height - y. PDF destinations live in default user space (MediaBox), so when CropBox is shifted the round-trip fromget_tocwas off byCropBox.y0.The conversion now uses
cropbox.y1 - y, which is the same as before when CropBox matches MediaBox.Fixes #4484