Repository navigation
Fix benchmark file links in Appendix 4 - #5134
Open
mmustafasenoglu wants to merge 1 commit into
Open
mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
The file names in the "Files used" table were interpreted text, so the link targets at the bottom of docs/app4.rst were never referenced and the table rendered without any download links. Also, the artifex.com sample URLs return 404 now, so point the targets at the archived copies at web.archive.org. Fixes pymupdf#5126
julian-smith-artifex-com
force-pushed
the
fix/app4-benchmark-links
branch
from
November 3, 2026 16:21
5f1d202 to
7f62e58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5126
The benchmark file names in the "Files used" table were written as interpreted text instead of references, so the link targets at the bottom of docs/app4.rst were never used and the table rendered without any download links. The artifex.com sample URLs also return 404 now, so the targets now point to the archived copies at web.archive.org (each archived file's size matches the size column in the table).
Changes:
_to the eight file names so they reference the existing targets