Repository navigation
Jules - improve wrapping of -ve page numbers - #5248
Merged
Merged
Conversation
…t.delete_pages(). Fixes #5240.
…f a loop. If x is negative, then `x % n` is equivalent to `while x < 0: x += n`.
JorjMcKie
approved these changes
Nov 3, 2026
Collaborator
|
Question: why do we need |
Collaborator
Author
|
This would change the behaviour of out-of-range +ve values - at the moment these are errors. There's a benefit to wrapping -ve values (e.g. -1 for last item is convenient). But there is not a corresponding benefit for accepting out-of-range +ve values, and i think such values are likely to be a mistake that we should not hide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document.delete_pages()raisesValueError: bad page number(s)on negative page numbers passed as two positional arguments #5240.%operator instead of loop to wrap -ve values.